From e2fb3681c930a5d61373f205533a1720b072d76b Mon Sep 17 00:00:00 2001
From: GauthamBanasandra <gautham.bangalore@gmail.com>
Date: Thu, 18 Jul 2019 00:11:38 +0530
Subject: [PATCH] src: add public virtual destructor for KVStore

As KVStore has derived classes, it is essential to
declare a public virtual destructor in the base
KVStore class. Otherwise, deleting derived class
instances using base class pointers would
potentially cause undefined behaviour.

Additionally, since we are implementing a non-default
destructor, the special member functions have also
been implemented in order to abide by the rule of five.
---
 src/env.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/env.h b/src/env.h
index 2bcb07a6333b6f..b94776bf43abf9 100644
--- a/src/env.h
+++ b/src/env.h
@@ -602,6 +602,13 @@ class AsyncRequest : public MemoryRetainer {
 
 class KVStore {
  public:
+  KVStore() = default;
+  virtual ~KVStore() = default;
+  KVStore(const KVStore&) = delete;
+  KVStore& operator=(const KVStore&) = delete;
+  KVStore(KVStore&&) = delete;
+  KVStore& operator=(KVStore&&) = delete;
+
   virtual v8::Local<v8::String> Get(v8::Isolate* isolate,
                                     v8::Local<v8::String> key) const = 0;
   virtual void Set(v8::Isolate* isolate,