buffer: use private properties for brand checks in File

PR-URL: #47154 Refs: #46904 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs · Apr 7, 2023 · e3d98c3 · e3d98c3
1 parent a3bffba
commit e3d98c3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 15 deletions.
diff --git a/lib/internal/file.js b/lib/internal/file.js
@@ -21,7 +21,6 @@ const {
 
 const {
   codes: {
-    ERR_INVALID_THIS,
     ERR_MISSING_ARGS,
   },
 } = require('internal/errors');
@@ -64,18 +63,10 @@ class File extends Blob {
   }
 
   get name() {
-    if (!this || !(#name in this)) {
-      throw new ERR_INVALID_THIS('File');
-    }
-
     return this.#name;
   }
 
   get lastModified() {
-    if (!this || !(#name in this)) {
-      throw new ERR_INVALID_THIS('File');
-    }
-
     return this.#lastModified;
   }
 

diff --git a/test/parallel/test-file.js b/test/parallel/test-file.js
@@ -146,10 +146,15 @@ const { inspect } = require('util');
 
 {
   const getter = Object.getOwnPropertyDescriptor(File.prototype, 'name').get;
-  assert.throws(
-    () => getter.call(undefined), // eslint-disable-line no-useless-call
-    {
-      code: 'ERR_INVALID_THIS',
-    }
-  );
+
+  [
+    undefined,
+    null,
+    true,
+  ].forEach((invalidThis) => {
+    assert.throws(
+      () => getter.call(invalidThis),
+      TypeError
+    );
+  });
 }