Skip to content

Commit

Permalink
src: update NODE_MODULE_VERSION to 129
Browse files Browse the repository at this point in the history
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 12.8.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
PR-URL: #54077
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
  • Loading branch information
targos committed Aug 16, 2024
1 parent 1dfa3b8 commit e945bd9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions doc/abi_version_registry.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"NODE_MODULE_VERSION": [
{ "modules": 128, "runtime":"electron", "variant": "electron", "versions": "32" },
{ "modules": 127, "runtime":"node", "variant": "v8_12.4", "versions": "22.0.0" },
{ "modules": 129,"runtime": "node", "variant": "v8_12.8", "versions": "23.0.0-pre" },
{ "modules": 128,"runtime": "electron", "variant": "electron", "versions": "32" },
{ "modules": 127,"runtime": "node", "variant": "v8_12.4", "versions": "22.0.0" },
{ "modules": 126,"runtime": "node", "variant": "v8_12.3", "versions": "22.0.0-pre" },
{ "modules": 125,"runtime": "electron", "variant": "electron", "versions": "31" },
{ "modules": 124,"runtime": "node", "variant": "v8_12.2", "versions": "22.0.0-pre" },
Expand Down
2 changes: 1 addition & 1 deletion src/node_version.h
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
#if defined(NODE_EMBEDDER_MODULE_VERSION)
#define NODE_MODULE_VERSION NODE_EMBEDDER_MODULE_VERSION
#else
#define NODE_MODULE_VERSION 127
#define NODE_MODULE_VERSION 129
#endif

// The NAPI_VERSION supported by the runtime. This is the inclusive range of
Expand Down

0 comments on commit e945bd9

Please sign in to comment.