From ea907762277bd43003d74f33a250cf9cec5a21ed Mon Sep 17 00:00:00 2001 From: Erin Bush Date: Fri, 12 Oct 2018 10:38:06 -0700 Subject: [PATCH] test: swap expected and actual arguments in assert.strictEqual() PR-URL: https://github.com/nodejs/node/pull/23542 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig Reviewed-By: Gireesh Punathil Reviewed-By: Trivikram Kamat Reviewed-By: Ruben Bridgewater --- test/pummel/test-net-pingpong-delay.js | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/test/pummel/test-net-pingpong-delay.js b/test/pummel/test-net-pingpong-delay.js index 25d610bf44a58b..392a6e0fed751e 100644 --- a/test/pummel/test-net-pingpong-delay.js +++ b/test/pummel/test-net-pingpong-delay.js @@ -35,11 +35,11 @@ function pingPongTest(port, host, on_complete) { socket.on('data', function(data) { console.log(data); - assert.strictEqual('PING', data); - assert.strictEqual('open', socket.readyState); - assert.strictEqual(true, count <= N); + assert.strictEqual(data, 'PING'); + assert.strictEqual(socket.readyState, 'open'); + assert.strictEqual(count <= N, true); setTimeout(function() { - assert.strictEqual('open', socket.readyState); + assert.strictEqual(socket.readyState, 'open'); socket.write('PONG'); }, DELAY); }); @@ -51,14 +51,14 @@ function pingPongTest(port, host, on_complete) { socket.on('end', function() { console.log('server-side socket EOF'); - assert.strictEqual('writeOnly', socket.readyState); + assert.strictEqual(socket.readyState, 'writeOnly'); socket.end(); }); socket.on('close', function(had_error) { console.log('server-side socket.end'); - assert.strictEqual(false, had_error); - assert.strictEqual('closed', socket.readyState); + assert.strictEqual(had_error, false); + assert.strictEqual(socket.readyState, 'closed'); socket.server.close(); }); }); @@ -69,17 +69,17 @@ function pingPongTest(port, host, on_complete) { client.setEncoding('utf8'); client.on('connect', function() { - assert.strictEqual('open', client.readyState); + assert.strictEqual(client.readyState, 'open'); client.write('PING'); }); client.on('data', function(data) { console.log(data); - assert.strictEqual('PONG', data); - assert.strictEqual('open', client.readyState); + assert.strictEqual(data, 'PONG'); + assert.strictEqual(client.readyState, 'open'); setTimeout(function() { - assert.strictEqual('open', client.readyState); + assert.strictEqual(client.readyState, 'open'); if (count++ < N) { client.write('PING'); } else { @@ -97,7 +97,7 @@ function pingPongTest(port, host, on_complete) { client.on('close', common.mustCall(function() { console.log('client.end'); - assert.strictEqual(N + 1, count); + assert.strictEqual(count, N + 1); assert.ok(client_ended); if (on_complete) on_complete(); }));