From eac377bc15518e54f88d430fca3e2d1d699b6790 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Mon, 19 Apr 2021 10:11:36 +0200 Subject: [PATCH] deps: V8: backport aaacffa1e003 Original commit message: PPC: skip all Simd tests on PPC As of https://crrev.com/c/2629465, Simd tests cannot pass on architectures without Simd support. Tests will need to be re-enabled once Simd support is fully implemented on PPC. Change-Id: I963639f1afa0c0ca7be3ca4b2fc06e874235b903 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2693056 Reviewed-by: Zhi An Ng Reviewed-by: Deepti Gandluri Commit-Queue: Milad Fa Cr-Commit-Position: refs/heads/master@{#72788} Refs: https://github.com/v8/v8/commit/aaacffa1e0039d23d46194b4f2d0ce553e17a4f5 PR-URL: https://github.com/nodejs/node/pull/38273 Backport-PR-URL: https://github.com/nodejs/node/pull/38991 Reviewed-By: Jiawen Geng Reviewed-By: Colin Ihrig Reviewed-By: Antoine du Hamel Reviewed-By: Michael Dawson Reviewed-By: Mary Marchini --- common.gypi | 2 +- deps/v8/test/message/message.status | 5 +++++ deps/v8/tools/testrunner/base_runner.py | 4 ++++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/common.gypi b/common.gypi index fbee26b668143a..a4f7e9d5aede99 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.5', + 'v8_embedder_string': '-node.6', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/test/message/message.status b/deps/v8/test/message/message.status index 03c7d6618c4f65..4301867fdf664f 100644 --- a/deps/v8/test/message/message.status +++ b/deps/v8/test/message/message.status @@ -70,6 +70,11 @@ }], ################################################################################ +['arch == ppc64', { + # Tests that require Simd enabled. + 'wasm-trace-memory': [SKIP], +}], + ['arch == mips64el or arch == mipsel', { # Tests that require Simd enabled. 'wasm-trace-memory': [SKIP], diff --git a/deps/v8/tools/testrunner/base_runner.py b/deps/v8/tools/testrunner/base_runner.py index 7b28d486cc9345..76aff630ff29b5 100644 --- a/deps/v8/tools/testrunner/base_runner.py +++ b/deps/v8/tools/testrunner/base_runner.py @@ -654,6 +654,10 @@ def _get_statusfile_variables(self, options): self.build_config.arch == 'mipsel': no_simd_sse = not simd_mips + # Set no_simd_sse on architectures without Simd enabled. + if self.build_config.arch == 'ppc64': + no_simd_sse = True + return { "arch": self.build_config.arch, "asan": self.build_config.asan,