http: don't emit 'finish' after 'error'

PR-URL: #32276 Refs: #28710 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
nodejs · Mar 24, 2020 · ef32069 · ef32069
1 parent 05fd160
commit ef32069
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js
@@ -736,6 +736,7 @@ OutgoingMessage.prototype.addTrailers = function addTrailers(headers) {
 };
 
 function onFinish(outmsg) {
+  if (outmsg && outmsg.socket && outmsg.socket._hadError) return;
   outmsg.emit('finish');
 }
 

diff --git a/test/parallel/test-tls-set-secure-context.js b/test/parallel/test-tls-set-secure-context.js
@@ -82,6 +82,7 @@ function makeRequest(port, id) {
       headers: { id }
     };
 
+    let errored = false;
     https.get(`https://localhost:${port}`, options, (res) => {
       let response = '';
 
@@ -95,7 +96,10 @@ function makeRequest(port, id) {
         resolve(response);
       }));
     }).on('error', (err) => {
+      errored = true;
       reject(err);
+    }).on('finish', () => {
+      assert.strictEqual(errored, false);
     });
   });
 }