module: 12.x self resolve flag as experimental modules

PR-URL: #31757 Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
nodejs · Feb 13, 2020 · f0b2d87 · f0b2d87
1 parent 7a5954e
commit f0b2d87
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/lib/internal/modules/cjs/loader.js b/lib/internal/modules/cjs/loader.js
@@ -432,6 +432,7 @@ function resolveBasePath(basePath, exts, isMain, trailingSlash, request) {
 }
 
 function trySelf(parentPath, isMain, request) {
+  if (!experimentalModules) return false;
   const { data: pkg, path: basePath } = readPackageScope(parentPath) || {};
   if (!pkg || pkg.exports === undefined) return false;
   if (typeof pkg.name !== 'string') return false;

diff --git a/test/es-module/test-esm-flagged-self.js b/test/es-module/test-esm-flagged-self.js
@@ -0,0 +1,16 @@
+'use strict';
+
+require('../common');
+const assert = require('assert');
+const path = require('path');
+const { createRequireFromPath } = require('module');
+
+const fixturesRequire =
+    createRequireFromPath(path.resolve(__dirname, '../fixtures/_'));
+
+try {
+  fixturesRequire('pkgexports/resolve-self');
+  assert(false);
+} catch (e) {
+  assert.strictEqual(e.code, 'MODULE_NOT_FOUND');
+}