Skip to content

Commit

Permalink
v8: backport header diff from 2e4a68733803
Browse files Browse the repository at this point in the history
Backport API-incompatible changes from
2e4a68733803 (“[v8] v8::StackTrace::AsArray returns correct array”).

Ref: https://codereview.chromium.org/2806373005
Ref: https://github.com/v8/v8/2e4a68733803

PR-URL: #12875
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
addaleax authored and jasnell committed May 28, 2017
1 parent a947cf9 commit f118f7a
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions deps/v8/include/v8.h
Original file line number Diff line number Diff line change
Expand Up @@ -1511,6 +1511,8 @@ class V8_EXPORT StackTrace {
/**
* Flags that determine what information is placed captured for each
* StackFrame when grabbing the current stack trace.
* Note: these options are deprecated and we always collect all available
* information (kDetailed).
*/
enum StackTraceOptions {
kLineNumber = 1,
Expand Down Expand Up @@ -1539,7 +1541,7 @@ class V8_EXPORT StackTrace {
/**
* Returns StackTrace as a v8::Array that contains StackFrame objects.
*/
Local<Array> AsArray();
V8_DEPRECATED("Use native API instead", Local<Array> AsArray());

/**
* Grab a snapshot of the current JavaScript execution stack.
Expand All @@ -1549,9 +1551,7 @@ class V8_EXPORT StackTrace {
* StackFrame.
*/
static Local<StackTrace> CurrentStackTrace(
Isolate* isolate,
int frame_limit,
StackTraceOptions options = kOverview);
Isolate* isolate, int frame_limit, StackTraceOptions options = kDetailed);
};


Expand Down

0 comments on commit f118f7a

Please sign in to comment.