From f1aae4334973132d8d78091d3300a4bf962c7bd9 Mon Sep 17 00:00:00 2001 From: Evan Lucas Date: Mon, 5 Apr 2021 08:33:35 -0500 Subject: [PATCH] test: correct test comment This corrects a comment on the signal type used in the test. PR-URL: https://github.com/nodejs/node/pull/38095 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: James M Snell --- test/abort/test-signal-handler.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/abort/test-signal-handler.js b/test/abort/test-signal-handler.js index 69ac95f5261fb7..6ee7e4098af702 100644 --- a/test/abort/test-signal-handler.js +++ b/test/abort/test-signal-handler.js @@ -17,7 +17,8 @@ if (process.argv[2] === 'child') { const child = spawnSync(process.execPath, ['--expose-internals', __filename, 'child'], { stdio: 'inherit' }); - // FreeBSD and macOS use SIGILL for the kind of crash we're causing here. + // FreeBSD uses SIGILL for this kind of crash. + // macOS uses SIGILL or SIGTRAP (arm64) for this kind of crash. assert(child.signal === 'SIGSEGV' || child.signal === 'SIGILL' || child.signal === 'SIGTRAP', `child.signal = ${child.signal}`); }