-
Notifications
You must be signed in to change notification settings - Fork 29.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tls,cli: add --trace-tls command-line flag
This commit adds a --trace-tls command-line flag. The purpose is to enable tracing of TLS connections without the need to modify existing application code. PR-URL: #27497 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
- Loading branch information
Showing
6 changed files
with
89 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
// Flags: --expose-internals | ||
'use strict'; | ||
const common = require('../common'); | ||
if (!common.hasCrypto) common.skip('missing crypto'); | ||
const fixtures = require('../common/fixtures'); | ||
|
||
// Test --trace-tls CLI flag. | ||
|
||
const assert = require('assert'); | ||
const { fork } = require('child_process'); | ||
|
||
if (process.argv[2] === 'test') | ||
return test(); | ||
|
||
const binding = require('internal/test/binding').internalBinding; | ||
|
||
if (!binding('tls_wrap').HAVE_SSL_TRACE) | ||
return common.skip('no SSL_trace() compiled into openssl'); | ||
|
||
const child = fork(__filename, ['test'], { | ||
silent: true, | ||
execArgv: ['--trace-tls'] | ||
}); | ||
|
||
let stderr = ''; | ||
child.stderr.setEncoding('utf8'); | ||
child.stderr.on('data', (data) => stderr += data); | ||
child.on('close', common.mustCall(() => { | ||
assert(/Warning: Enabling --trace-tls can expose sensitive/.test(stderr)); | ||
assert(/Received Record/.test(stderr)); | ||
assert(/ClientHello/.test(stderr)); | ||
})); | ||
|
||
// For debugging and observation of actual trace output. | ||
child.stderr.pipe(process.stderr); | ||
child.stdout.pipe(process.stdout); | ||
|
||
child.on('exit', common.mustCall((code) => { | ||
assert.strictEqual(code, 0); | ||
})); | ||
|
||
function test() { | ||
const { | ||
connect, keys | ||
} = require(fixtures.path('tls-connect')); | ||
|
||
connect({ | ||
client: { | ||
checkServerIdentity: (servername, cert) => { }, | ||
ca: `${keys.agent1.cert}\n${keys.agent6.ca}`, | ||
}, | ||
server: { | ||
cert: keys.agent6.cert, | ||
key: keys.agent6.key | ||
}, | ||
}, common.mustCall((err, pair, cleanup) => { | ||
return cleanup(); | ||
})); | ||
} |