From f3c0b8cd6ea6b653656656648f77d2dd248dc22c Mon Sep 17 00:00:00 2001 From: Jaime Bernardo Date: Fri, 30 Jun 2017 19:35:52 +0100 Subject: [PATCH] test,fs: delay unlink in test-regress-GH-4027.js The sequential/test-regress-GH-4027 test is flaky with an increased system load, failing when the watched file is unlinked before the first state of the watched file is retrieved. After increasing the delay before unlinking and calling setTimeout after watchFile, the flakiness stopped reproducing. PR-URL: https://github.com/nodejs/node/pull/14010 Fixes: https://github.com/nodejs/node/issues/13800 Reviewed-By: Rich Trott Reviewed-By: Refael Ackermann --- test/sequential/test-regress-GH-4027.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/sequential/test-regress-GH-4027.js b/test/sequential/test-regress-GH-4027.js index 8d9c6bb1ad795a..a1332e71c4c320 100644 --- a/test/sequential/test-regress-GH-4027.js +++ b/test/sequential/test-regress-GH-4027.js @@ -8,10 +8,11 @@ common.refreshTmpDir(); const filename = path.join(common.tmpDir, 'watched'); fs.writeFileSync(filename, 'quis custodiet ipsos custodes'); -setTimeout(fs.unlinkSync, 100, filename); fs.watchFile(filename, { interval: 50 }, common.mustCall(function(curr, prev) { assert.strictEqual(prev.nlink, 1); assert.strictEqual(curr.nlink, 0); fs.unwatchFile(filename); })); + +setTimeout(fs.unlinkSync, common.platformTimeout(300), filename);