From f4697ba718bed0fcd1a1cebbe1a5dbe8f4893ebf Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Tue, 22 Jan 2019 02:51:44 +0800 Subject: [PATCH] test: clarify the path relativeness of WPT runner classes PR-URL: https://github.com/nodejs/node/pull/25616 Reviewed-By: Anna Henningsen Reviewed-By: Gus Caplan --- test/common/wpt.js | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/test/common/wpt.js b/test/common/wpt.js index 0b4424ef73b224..f9e48c5f977beb 100644 --- a/test/common/wpt.js +++ b/test/common/wpt.js @@ -127,13 +127,15 @@ class StatusRuleSet { class WPTTest { /** - * @param {string} mod - * @param {string} filename + * @param {string} mod name of the WPT module, e.g. + * 'html/webappapis/microtask-queuing' + * @param {string} filename path of the test, relative to mod, e.g. + * 'test.any.js' * @param {StatusRule[]} rules */ constructor(mod, filename, rules) { - this.module = mod; // name of the WPT module, e.g. 'url' - this.filename = filename; // name of the test file + this.module = mod; + this.filename = filename; this.requires = new Set(); this.failReasons = []; @@ -204,6 +206,9 @@ const intlRequirements = new IntlRequirement(); class StatusLoader { + /** + * @param {string} path relative path of the WPT subset + */ constructor(path) { this.path = path; this.loaded = false;