From f4f191bbc26c367ed8fa56c2d1297ef437c5f0fb Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Tue, 21 Jul 2020 08:56:47 +0800 Subject: [PATCH] build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot Otherwise the build would fail with `./configure --experimental-quic --ninja` as the list of per-Environment values would not match and the code cache builder would not generate code cache for the quic JS sources. This is more or less a band-aid - a proper fix would be to aggregate these flags into something that can be included by all these different binary targets. See https://github.com/nodejs/node/issues/31074. PR-URL: https://github.com/nodejs/node/pull/34454 Fixes: https://github.com/nodejs/node/issues/34435 Reviewed-By: James M Snell Reviewed-By: Jiawen Geng --- node.gyp | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/node.gyp b/node.gyp index acaf2cef8fb10a..497c06c6bc0a6c 100644 --- a/node.gyp +++ b/node.gyp @@ -1376,6 +1376,11 @@ 'HAVE_OPENSSL=1', ], }], + [ 'node_use_openssl=="true" and experimental_quic==1', { + 'defines': [ + 'NODE_EXPERIMENTAL_QUIC=1', + ], + }], ['v8_enable_inspector==1', { 'defines': [ 'HAVE_INSPECTOR=1', @@ -1430,6 +1435,11 @@ 'HAVE_OPENSSL=1', ], }], + [ 'node_use_openssl=="true" and experimental_quic==1', { + 'defines': [ + 'NODE_EXPERIMENTAL_QUIC=1', + ], + }], ['v8_enable_inspector==1', { 'defines': [ 'HAVE_INSPECTOR=1',