From f99e6988557e17624962c2bc36bebd7fa3119eec Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 19 Oct 2016 15:57:00 -0700 Subject: [PATCH] test: remove arbitrary timer `test-dgram-send-callback-buffer-length` was timing out (via the 200ms timeout in the code) on FreeBSD in CI. The 200ms timeout is arbitrary and not necessary. Remove it. PR-URL: https://github.com/nodejs/node/pull/9197 Reviewed-By: Colin Ihrig Reviewed-By: Santiago Gimeno Reviewed-By: James M Snell Reviewed-By: Luigi Pinca --- test/parallel/test-dgram-send-callback-buffer-length.js | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/test/parallel/test-dgram-send-callback-buffer-length.js b/test/parallel/test-dgram-send-callback-buffer-length.js index b44393898331ed..76af0e14635be0 100644 --- a/test/parallel/test-dgram-send-callback-buffer-length.js +++ b/test/parallel/test-dgram-send-callback-buffer-length.js @@ -6,18 +6,13 @@ const assert = require('assert'); const dgram = require('dgram'); const client = dgram.createSocket('udp4'); -const timer = setTimeout(function() { - throw new Error('Timeout'); -}, common.platformTimeout(200)); - const buf = Buffer.allocUnsafe(256); const offset = 20; const len = buf.length - offset; const messageSent = common.mustCall(function messageSent(err, bytes) { - assert.notEqual(bytes, buf.length); - assert.equal(bytes, buf.length - offset); - clearTimeout(timer); + assert.notStrictEqual(bytes, buf.length); + assert.strictEqual(bytes, buf.length - offset); client.close(); });