From fb03faa8353a900c4ad7ef887321bedae0d6dfd9 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 26 Sep 2018 21:32:37 -0700 Subject: [PATCH] build: move addons message in Makefile MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Displaying a message about building addons before building docs can be confusing when troubleshooting. (This just happened to me.) Move the message about building addons to just before the step for building addons. PR-URL: https://github.com/nodejs/node/pull/23114 Reviewed-By: Daniel Bevenius Reviewed-By: Michaël Zasso Reviewed-By: Colin Ihrig Reviewed-By: Anna Henningsen Reviewed-By: Sakthipriyan Vairamani --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 74f3067025448e..94f31afa58b80b 100644 --- a/Makefile +++ b/Makefile @@ -278,9 +278,9 @@ jstest: build-addons build-addons-napi ## Runs addon tests and JS tests .PHONY: test # This does not run tests of third-party libraries inside deps. test: all ## Runs default tests, linters, and builds docs. + $(MAKE) -s test-doc @echo "Build the addons before running the tests so the test results" @echo "can be displayed together" - $(MAKE) -s test-doc $(MAKE) -s build-addons $(MAKE) -s build-addons-napi $(MAKE) -s cctest