From fbf8e60679ca3493a94c02405e23d80214f4d2e6 Mon Sep 17 00:00:00 2001 From: Gireesh Punathil Date: Mon, 21 Jan 2019 20:22:08 +0530 Subject: [PATCH] test: revoke flaky designation for tests A number of tests that were `flaked` recently are proved to have failing reason identified in https://github.com/nodejs/node/issues/25007 and resolution identified in https://github.com/nodejs/node/pull/25061 Revoke flaky designation of all these tests as the said PR is landed. PR-URL: https://github.com/nodejs/node/pull/25611 Reviewed-By: Sakthipriyan Vairamani Reviewed-By: Rich Trott Reviewed-By: Anna Henningsen Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Richard Lau Reviewed-By: Beth Griggs --- test/parallel/parallel.status | 8 -------- test/sequential/sequential.status | 9 --------- 2 files changed, 17 deletions(-) diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status index b9ad12b25d7a22..7de71e345f725e 100644 --- a/test/parallel/parallel.status +++ b/test/parallel/parallel.status @@ -5,12 +5,8 @@ prefix parallel # sample-test : PASS,FLAKY [true] # This section applies to all platforms -# https://github.com/nodejs/node/issues/25029 -test-child-process-execfile: PASS,FLAKY # https://github.com/nodejs/node/issues/23207 test-net-connect-options-port: PASS,FLAKY -# https://github.com/nodejs/node/issues/25033 -test-child-process-exit-code: PASS,FLAKY # https://github.com/nodejs/node/issues/24305 test-trace-events-api-worker-disabled: PASS,FLAKY @@ -36,7 +32,3 @@ test-worker-prof: PASS,FLAKY [$system==freebsd] [$system==aix] -# https://github.com/nodejs/node/issues/25029 -test-child-process-execfile: PASS,FLAKY -# https://github.com/nodejs/node/issues/25068 -test-util-callbackify: PASS,FLAKY diff --git a/test/sequential/sequential.status b/test/sequential/sequential.status index 3cbb1982a34a21..d9963bc6f77328 100644 --- a/test/sequential/sequential.status +++ b/test/sequential/sequential.status @@ -7,11 +7,6 @@ prefix sequential [true] # This section applies to all platforms # https://github.com/nodejs/node/issues/22336 test-gc-http-client: PASS,FLAKY -# https://github.com/nodejs/node/issues/24403 -test-cli-syntax-bad: PASS,FLAKY -test-cli-syntax-file-not-found: PASS,FLAKY -test-cli-syntax-good: PASS,FLAKY -test-cli-syntax-require: PASS,FLAKY [$system==win32] # https://github.com/nodejs/node/issues/22327 @@ -26,9 +21,5 @@ test-http2-large-file: PASS, FLAKY [$system==freebsd] [$system==aix] -# https://github.com/nodejs/node/issues/24921 -test-child-process-execsync: PASS, FLAKY -# https://github.com/nodejs/node/issues/25047 -test-inspector-debug-end: PASS, FLAKY [$arch==arm]