Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nonstandard URL.originFor #10374

Closed
domenic opened this issue Dec 21, 2016 · 3 comments
Closed

Remove nonstandard URL.originFor #10374

domenic opened this issue Dec 21, 2016 · 3 comments
Labels
url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@domenic
Copy link
Contributor

domenic commented Dec 21, 2016

Apparently the new WHATWG URL API includes a nonstandard static method originFor. Its presence encourages writing code that is not interoperable between Node.js and browsers. It should be removed.
@domenic domenic mentioned this issue Dec 21, 2016
Closed
2 tasks
@addaleax addaleax added the url Issues and PRs related to the legacy built-in url module. label Dec 21, 2016
@jasnell
Copy link
Member

jasnell commented Dec 21, 2016

Not really removed so much as moved... it should hang off the require('url') module rather than require('url').URL

@domenic
Copy link
Contributor Author

domenic commented Dec 21, 2016

Hmm, what is the benefit of that over new URL(...).origin?

@joyeecheung joyeecheung mentioned this issue Dec 22, 2016
Closed
3 tasks
@targos
Copy link
Member

targos commented Jan 2, 2017

Moved to require('url') in abc1633.

@targos targos closed this as completed Jan 2, 2017
@joyeecheung joyeecheung added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Jan 5, 2017
@TimothyGu TimothyGu mentioned this issue Jan 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jasnell @domenic @addaleax @targos @joyeecheung