Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N-API: add function for fatal error #13927

Closed
mhdawson opened this issue Jun 26, 2017 · 2 comments
Closed

N-API: add function for fatal error #13927

mhdawson opened this issue Jun 26, 2017 · 2 comments
Labels
node-api Issues and PRs related to the Node-API.

Comments

@mhdawson
Copy link
Member

  • Version: ALL
  • Platform: ALL
  • Subsystem: ALL

Expose node::FatalError() (or similar) as a napi_fatal_error() API.

See nodejs/node-addon-api#32 (comment) for a scenario where it is needed.

The N-API team will get to this based on priorities, but this is a good place for others to contribute as well. If you start working on this, assign the issue to yourself and add a comment that you are working on it.
@mscdex mscdex added the node-api Issues and PRs related to the Node-API. label Jun 26, 2017
@mhdawson mhdawson mentioned this issue Jun 26, 2017
Closed
@kfarnung
Copy link
Contributor

I'm planning to take a look at it this week.

/cc @jasongin

@mhdawson mhdawson mentioned this issue Jun 26, 2017
Closed
@kfarnung kfarnung mentioned this issue Jun 29, 2017
Closed
4 tasks
cjihrig referenced this issue Jul 14, 2017
@kfarnung @mhdawson
n-api: add napi_fatal_error API
73078d6 
PR-URL: #13971
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@cjihrig
Copy link
Contributor

cjihrig commented Jul 14, 2017

Closed by #13971

@cjihrig cjihrig closed this as completed Jul 14, 2017
This was referenced Sep 15, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 16, 2021
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Feb 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mscdex @kfarnung @cjihrig @mhdawson