-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: test with --with-snapshot
on the slower platforms
#14222
Comments
I don't think that it is a good idea to run the tests with snapshots, but release builds without snapshots. |
I agree with @evanlucas. And, as painful as the CI may currently be, I think we should try to work through the snapshot issue before taking any drastic (maybe too strong of a word) measures. |
Random sample Δt numbers:
|
Compromise: a check box in the submit job form? |
I'm in agreement that we need to test in the same way that we ship. |
I want to make an argument for leniency.
tl;dr adding a checkbox (enable / disable snapshot) in the job submission form might be a good thing, by it increasing coverage. |
@refack snapshots have been re-enabled so this can be closed right? Reopen if I'm wrong. |
Ref: #14214 (comment)
Should we run the CI tests configured
--with-snapshot
for the slower (Δt > 50%) platforms? Just so we get back to reasonable time frames? (node-test-commit-arm
up to ~1h38m from ~29m)/cc @nodejs/testing @nodejs/release @nodejs/build
The text was updated successfully, but these errors were encountered: