Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import TextDecoder/TextEncoder Web Platform Tests #15442

Closed
TimothyGu opened this issue Sep 17, 2017 · 5 comments
Closed

Import TextDecoder/TextEncoder Web Platform Tests #15442

TimothyGu opened this issue Sep 17, 2017 · 5 comments
Labels
i18n-api Issues and PRs related to the i18n implementation. test Issues and PRs related to the tests. wip Issues and PRs that are still a work in progress.

Comments

@TimothyGu
Copy link
Member

See https://github.com/w3c/web-platform-tests/tree/master/encoding. Given that we already have a polyfill for testharness.js it should not be entirely difficult. However, care must be taken to comment out the portions of WPT that either only run in browsers, or are not currently supported by Node.js ('iso-8859-16' encoding), or are not supported by Node.js built with small-icu.
@TimothyGu TimothyGu added i18n-api Issues and PRs related to the i18n implementation. mentor-available test Issues and PRs related to the tests. labels Sep 17, 2017
@jrasanen
Copy link
Contributor

I'd be interested to help on this one

@kasimdoctor
Copy link

I'd be glad to help on this too! Is this already taken OR is there room for more than 1 person to work on this?

@TimothyGu TimothyGu added wip Issues and PRs that are still a work in progress. and removed mentor-available labels Oct 15, 2017
@TimothyGu
Copy link
Member Author

@kasimdoctor This has already been worked on in #15743. Sorry for not updating the issue labels in time!

@gireeshpunathil
Copy link
Member

associated PR is complete. Close?

@jasnell
Copy link
Member

jasnell commented Oct 30, 2017

Closing :-)

@jasnell jasnell closed this as completed Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
i18n-api Issues and PRs related to the i18n implementation. test Issues and PRs related to the tests. wip Issues and PRs that are still a work in progress.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jrasanen @jasnell @TimothyGu @kasimdoctor @gireeshpunathil