Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mass early fails in CI #16223

Closed
vsemozhetbyt opened this issue Oct 15, 2017 · 2 comments
Closed

mass early fails in CI #16223

vsemozhetbyt opened this issue Oct 15, 2017 · 2 comments

Comments

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Oct 15, 2017 •
edited
Loading

See https://ci.nodejs.org/job/node-test-commit/13159/
@addaleax
Copy link
Member

I think this was an actual issue with #16221 – in bootstrap_node.js, events is require()d before global.process = process is set up. The PR has been updated since to account for this, so I think this issue can be closed :)

@vsemozhetbyt
Copy link
Contributor Author

@addaleax Thank you. Sorry for the false alarm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@addaleax @vsemozhetbyt