Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: label for pre-backport request #16570

Closed
joyeecheung opened this issue Oct 28, 2017 · 6 comments
Closed

meta: label for pre-backport request #16570

joyeecheung opened this issue Oct 28, 2017 · 6 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Oct 28, 2017

Spun off from #16249 , I think we can add a label and use it first to see how it goes. I am not really a master at naming things, maybe should-prebackport?

@joyeecheung joyeecheung added the meta Issues and PRs related to the general management of the project. label Oct 28, 2017
@apapirovski
Copy link
Member

apapirovski commented Oct 28, 2017

Could be something like prebackport-requested-vXYZ... I'm guessing there'll be some that need multiple prebackports and others that don't. But I'm bad at naming so y'kno... 😅

@lance
Copy link
Member

lance commented Oct 28, 2017

On a related note (and maybe I should just create an issue for this), I have been doing a few backports in the past week, and I'm not 100% clear on how issues should be labeled when submitting a backport PR. The docs say "After the PR lands replace the backport-requested-v6.x label on the original PR with backported-to-v6.x.". This makes sense to me.

However, I noticed in #16020 (comment) that it was labeled backported-to-v8.x in spite of the backport PR still being open. Maybe it was just a mistaken slip of a click. But I think it would be useful to have a label marking the original PR as having been backported to a staging pull request, but that staging PR has not yet landed. For those doing the work to get commits from vX.x-staging to vX.x it seems like it would be useful to find what work needs to be done. And for those doing the work to backport the PRs to staging, it's helpful for filtering out those that have already been backported.

@joyeecheung
Copy link
Member Author

cc @nodejs/lts

@gibfahn
Copy link
Member

gibfahn commented Oct 30, 2017

Spun off from #16249 , I think we can add a label and use it first to see how it goes. I am not really a master at naming things, maybe should-prebackport?

Couldn't we just use the existing backport-requested labels? I don't think there's any difference between a pre-backport and a backport other than the fact that it's requested before the PR lands.

However, I noticed in #16020 (comment) that it was labeled backported-to-v8.x in spite of the backport PR still being open. Maybe it was just a mistaken slip of a click. But I think it would be useful to have a label marking the original PR as having been backported to a staging pull request, but that staging PR has not yet landed.

I see the use, but it's yet more manual effort for the backporter, and also more complexity for people to learn to understand the process. I think I'd be okay with it if it could be automated. Also we really want to be landing backport PRs within 24 hours, otherwise they tend to get stale.

@joyeecheung
Copy link
Member Author

Couldn't we just use the existing backport-requested labels? I don't think there's any difference between a pre-backport and a backport other than the fact that it's requested before the PR lands.

Oh right, haven't thought about that....

I see the use, but it's yet more manual effort for the backporter, and also more complexity for people to learn to understand the process. I think I'd be okay with it if it could be automated.

Added to my backlog..

@joyeecheung
Copy link
Member Author

I am going to close this because I think we can just use backport-requested labels for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests

4 participants