Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meaningful node inspect context titles #16600

Closed
filmerjarred opened this issue Oct 30, 2017 · 4 comments
Closed

Meaningful node inspect context titles #16600

filmerjarred opened this issue Oct 30, 2017 · 4 comments
Labels
feature request Issues that request new features to be added to Node.js. inspector Issues and PRs related to the V8 inspector protocol

Comments

@filmerjarred
Copy link

Problem: When inspecting multiple node contexts using the new --inspect flag paired with the dedicated node inspect in chrome dev tools, knowing which process you're currently inspecting can be confusing as they're all called "Nodejs Main Context" as per (I think):

contextCreated(env->context(), "Node.js Main Context");

Potential solutions:

  • Taking an optional environment variable like NODE_CONTEXT_TITLE (looks like the env might already be being passed in there, not sure if same env as process.env?)
  • Could pass in a flag along the lines of --inspect-context-title
@mscdex mscdex added feature request Issues that request new features to be added to Node.js. inspector Issues and PRs related to the V8 inspector protocol labels Oct 30, 2017
@Fishrock123
Copy link
Contributor

Shouldn't it just take process.title?

@filmerjarred
Copy link
Author

Often the process title is just 'npm' or 'node' so you get the same problem. Ideally, I'd like to click the context dropdown and see 'Service A' and 'Service B' for ease of debugging. Changing process.title also has limitations and side effects on other things as I understand it

@addaleax
Copy link
Member

@bnoordhuis I guess this was fixed by #17087?

@filmerjarred
Copy link
Author

Looks to be 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues that request new features to be added to Node.js. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

No branches or pull requests

4 participants