Review of last 3 months of floated V8 patches

[MylesBorins]

So I went and reviewed all the patches that have landed on master against deps/v8 since updating to 6.0 (this seemed reasonable as the lowest TF + I release we are shipping right now is 6.1

Below is the list. It is organized by which version these patches live on upstream and within those sub groups chronologically. I'm going to review the 8.x and 9.x branches and ensure that we haven't missed specific patches (or lost them during major updates). I also think that it is worth reviewing these and seeing if we can get any of them backported to 6.2, or at the very least 6.3 (for the few being floated from 6.4).

I'd be interested to see if we can make some sort of process around landing these to ensure that we have at least attempted to get them landed upstream before we float them in node.

6.4

• ccab7d1 - deps: cherry-pick cc55747 from V8 upstream (8 hours ago)
  • (ofrobots) pinged issue about merging back upstream.
• e5238ed - deps: cherry-pick b8331cc030 from upstream V8 (33 hours ago)
  • (ofrobots) @ak239 does it make sense to get this fix merged back to 6.2 and 6.3 upstream?
• 801e61a - deps: cherry-pick 37a3a15c3 from V8 upstream (3 weeks ago)
  • (ofrobots) I suspect this wouldn't get accepted for a merge back upstream, but I have asked on the PR.

6.3

• c087502 - deps: V8: backport b1cd96e from upstream (12 days ago)
• edd78f8 - deps: cherry-pick e0d64dc from upstream V8 (13 days ago)<Michaël Zasso>
• cf38d2f - deps: cherry-pick 676c413 from upstream V8 (13 days ago)<Michaël Zasso>
• 55a4d66 - deps: cherry-pick 2c75616 from upstream V8 (13 days ago)<Michaël Zasso>
• c39caa9 - deps: backport 0f1dfae from V8 upstream (3 weeks ago)
• d7456ab - deps: cherry-pick 9b21865822243 from V8 upstream (3 weeks ago)
• 2780f01 - deps: backport b096c44 from upstream V8 (3 weeks ago)<Michaël Zasso>
• acb9b8f - deps: backport b096c44 from upstream V8 (3 weeks ago)<Michaël Zasso>
• be2a5b3 - deps: cherry-pick f4a2b7f3 from V8 upstream. (5 weeks ago)
• 8403d6b - deps: cherry-pick 9b21865822243 from V8 upstream (8 weeks ago)
• 8403d6b - deps: cherry-pick 9b21865822243 from V8 upstream (8 weeks ago)

6.2

• 9910860 - deps: V8: cherry-pick 163d360 from upstream (6 weeks ago)
• 2f2f1cf - deps: cherry-pick 0353a1e from upstream V8 (6 weeks ago)<Michaël Zasso>
• 01a1812 - deps: cherry-pick b6158eb6befae from V8 upstream (8 weeks ago)
• 9c3182e - deps: cherry-pick 1aead19 from upstream V8 (8 weeks ago)
• bd6907b - deps: cherry-pick e020aae394 from V8 upstream (8 weeks ago)
• e55b7f3 - deps: backport f9c4b7a from upstream V8 (8 weeks ago)
• 5976e0f - deps: backport bca8409 from upstream V8 (8 weeks ago)
• e1c37b3 - deps: backport 6e9e2e5 from upstream V8 (8 weeks ago)
• e202d85 - deps: cherry-pick f19b889 from upstream V8 (8 weeks ago)<Michaël Zasso>
• ca78180 - deps: cherry-pick 1aead19 from upstream V8 (9 weeks ago)
• 64f59be - deps: cherry-pick e020aae394 from V8 upstream (3 months ago)
• 64162a1 - deps: backport bca8409 from upstream V8 (3 months ago)
• 73c59bb - deps: cherry-pick f19b889 from V8 upstream (3 months ago)

6.1

• 81b2a89 - deps: cherry-pick 5005faed5 from V8 upstream (9 weeks ago)
• d348512 - deps: backport d727680 from V8 upstream (3 months ago)
• fabe1b4 - deps: backport f9c4b7a from upstream V8 (3 months ago)
• 354a17b - deps: backport 6e9e2e5 from upstream V8 (3 months ago)
• 4fbedbb - deps: backport 3d8e87a from upstream V8 (3 months ago)
• 832a87f - deps: backport 5152d97 from upstream V8 (3 months ago)
• 4f21834 - deps: backport c4852ea from upstream V8 (3 months ago)
• 8096791 - deps: cherry-pick fa4ec9f from V8 upstream (3 months ago)

???

• 31ce2c1 - deps: add postmortem metadata for V8 TurboFan (8 weeks ago)<Michaël Zasso>
  • (ofrobots) Landed in 6.3.150.
• 694ef89 - deps: fix addons compilation with VS2013 (8 weeks ago)
  • (ofrobots) This fix is not present upstream AFAIK?
• c6e165b - deps: limit regress/regress-crbug-514081 v8 test (8 weeks ago)
  • (ofrobots) This fix is not present upstream AFAIK?
• cd9f81d - deps: fix inspector v8 test (3 months ago)
  • (ofrobots) Landed in 6.2.118

[MylesBorins]

/cc @nodejs/v8 @targos

[alexkozy]

We do not use gyp in Chromium so b8331cc030 does not affect Chromium. I think this one is not qualified as merge candidate in V8.

[MylesBorins]

@ak239 b8331cc030 is a change to the inspector not gyp... the change to common.gypi is an internal marker for keeping track of patches in node core