-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to compile nodejs on Freebsd-current/Armv7 #16943
Comments
Hi, thanks for the report! A couple things:
|
I am not cross compiling I am compiling on actual hardware. It built successfully using the ports system but was unable to run npm. I am using the default clang compiler because when I tried switching it to gcc-7 nodejs complained about not having Clang. Its going to take a while for the grep so I'll post back once I grep those two things in /usr/include because its going to take a while. Version of clang I have is: FreeBSD clang version 5.0.0 (tags/RELEASE_500/final 312559) (based on LLVM 5.0.0svn) |
Untested, but I think the diff should look something like this (should be upstreamed to V8 first): diff --git a/deps/v8/src/libsampler/sampler.cc b/deps/v8/src/libsampler/sampler.cc
index 7519720beb..3dc23dac8b 100644
--- a/deps/v8/src/libsampler/sampler.cc
+++ b/deps/v8/src/libsampler/sampler.cc
@@ -506,9 +506,9 @@ void SignalHandler::FillRegisterState(void* context, RegisterState* state) {
state->sp = reinterpret_cast<void*>(mcontext.mc_rsp);
state->fp = reinterpret_cast<void*>(mcontext.mc_rbp);
#elif V8_HOST_ARCH_ARM
- state->pc = reinterpret_cast<void*>(mcontext.mc_r15);
- state->sp = reinterpret_cast<void*>(mcontext.mc_r13);
- state->fp = reinterpret_cast<void*>(mcontext.mc_r11);
+ state->pc = reinterpret_cast<void*>(mcontext.__gregs[_REG_M15]);
+ state->sp = reinterpret_cast<void*>(mcontext.__gregs[_REG_M13]);
+ state->fp = reinterpret_cast<void*>(mcontext.__gregs[_REG_M11]);
#endif // V8_HOST_ARCH_*
#elif V8_OS_NETBSD
#if V8_HOST_ARCH_IA32 |
@blubaustin If you're still interested in pursuing this, let me know. I'll close this out in the mean time. |
Anytime I try to compile nodejs nightly I keep getting an error here is the full build:
compiler output
The text was updated successfully, but these errors were encountered: