Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Reviewing Pull Requests" section in the contributing guide is not written in the contributor's perspective #18363

Closed
joyeecheung opened this issue Jan 25, 2018 · 2 comments
Assignees
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Jan 25, 2018

Just reading through #17285 (comment) and discovered that we don't seem to have a document written in a new contributor's perspective about what a PR needs to proceed or to be blocked. I've split the contributing guide into separate documents and the part about reviews seem to be written in reviewers' perspective which is odd, considering we already have a collaborator guide that covers that:
https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#reviewing-pull-requests

Opening this mostly to remind me to update (completely rewrite?) this part...

@joyeecheung joyeecheung self-assigned this Jan 25, 2018
@joyeecheung joyeecheung added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Jan 25, 2018
@BridgeAR
Copy link
Member

Ping @joyeecheung

@apapirovski
Copy link
Member

I'm going to close this given the lack of movement. It's possible this isn't actually needed?

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests

3 participants