Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: TLSSocket options not initialized #2394

Closed
jasnell opened this issue Aug 16, 2015 · 4 comments
Closed

tls: TLSSocket options not initialized #2394

jasnell opened this issue Aug 16, 2015 · 4 comments
Labels
good first issue Issues that are suitable for first-time contributors. tls Issues and PRs related to the tls subsystem.

Comments

@jasnell
Copy link
Member

jasnell commented Aug 16, 2015

Per: nodejs/node-v0.x-archive#7218 by @adammw

This was a PR originally opened against joyent/node but never landed. On the
TLSSocket constructor, the options parameter is not verified to be undefined and
the code assume's it's not. The PR was originally reviewed by @indutny but had
some issues that were never fully resolved. The PR would need to be reopened
here and updated before it can land.
@brendanashworth brendanashworth added the tls Issues and PRs related to the tls subsystem. label Aug 16, 2015
@Fishrock123 Fishrock123 added the good first issue Issues that are suitable for first-time contributors. label Aug 25, 2015
@jhamhader jhamhader mentioned this issue Aug 29, 2015
Closed
@kulkarniankita
Copy link

If no one else has picked this up, can I work on this?

@jhamhader
Copy link
Contributor

I'm on it, and my PR is waiting for merge :)

@jhamhader
Copy link
Contributor

Landed on #2614

@evanlucas
Copy link
Contributor

This was landed in adfd20b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jasnell @evanlucas @Fishrock123 @kulkarniankita @brendanashworth @jhamhader