-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using GitHub Lock App for closed issues/PRs on NodeJS core? #25209
Comments
has there been a problem with comments in closed issues that shouldn't be in those closed issues? if so this sounds ok. |
|
I don't think locking a closed issue after a period of inactivity is particularly useful? Closing an issue after a period of inactivity on the other hand, is more useful. |
Unless there has been a problem that would be fixed by locking after some period of time, I'd favor leaving as is. |
I'd be in favor of auto-closing old issues. We have a long (loooong) backlog of probably-stale issues that no one is looking at, with many where discussion has meandered so much that no one is really sure anymore what they're even about. |
There are 3 options in the end:
IMO, option 2 is a fair trade-off and still allows conversations but prunes the backlog. (Just my 2 cents |
|
@sam-github This can be done with the suggested bot, (example: 2 months w/o activities). Then you can "announce" the close and give another grace period so the user can bump the issue again (if still relevant). Example here: nuxt/nuxt#3948 (comment) |
@manniL That last seems really helpful to me. I think a few people have been basically doing this manually, @Trott and @bnoordhuis leap to mind, and it must be pretty tedious. Automating the nudge and closing out the issue if no one responds seems really useful. Is the locking which was done in the example you linked required, or can it just be closed? |
@sam-github Our config for the stale bot can be found here |
This issue is now stale 😄 What should we do? |
Hi,
This suggestion came from Twitter discussion started by @bcoe (link)
GitHub App lock locks closed issues and pull requests after a period of inactivity.
How about using this App on NodeJS core repo?
The only concern I see is comments related to backporting in Pull Requests.
The PR is still open to comments from collaborators so it shouldn't be a concern. And in a rare case, a collaborator can always unlock the PR if comments/response is required from a non-collaborator.
Regards,
Trivikram
The text was updated successfully, but these errors were encountered: