-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
investigate test/tick-processor/test-tick-processor-builtin failures #25891
Comments
Running the |
It passed in the coverage job at https://ci.nodejs.org/view/All/job/node-test-commit-linux-coverage-daily/28/nodes=benchmark/ and in the CI above. Last thing: Can someone with macOS Mojave try running it? If it passes for someone else on Mojave, I'm OK closing this as my own personal computer's issue. @nodejs/platform-macos |
At commit 28c0f84:
Note the 'tic' vs. 'tick'. |
is this still an issue? |
Possibly... testing today, the test doesn't terminate in any reasonable time frame:
|
test/tick-processor/test-tick-processor-builtin.js fails consistently for me. Since this test is not run in CI or typically locally (unless you run
make test-tick-processor
, which almost no one does, or the brand newmake test-all-suites
), it may be broken everywhere. Or maybe it's just me. Anyone?/ping @indutny who has the biggest
git blame
footprint on that file (sorry if that's a bad metric to use and I'm pinging the wrong person)The text was updated successfully, but these errors were encountered: