[N-API] Missing module object at initialization time

[raffaeler]

• Version: v8.9.4
• Platform: Windows 10 x64

With the legacy api, I obtain the addon module using this code:

void Init(Local<Object> exports, Local<Object> module) {
  NODE_SET_METHOD(module, "exports", CreateObject);
}
NODE_MODULE(NODE_GYP_MODULE_NAME, Init)

Now I found the way to access the _module internal variable but it is a plain structure and not a Napi::Value.
The reason for needing the Module is accessing, for example, the full pathname of the C++ addon.

[mhdawson]

Can you add how you accessed the _module internal variable?

[raffaeler]

Sure, here it is the relevant code:

#define NODE_ADDON_API_DISABLE_DEPRECATED
#include <napi.h>

namespace xcoreplus
{
	using namespace Napi;
	using namespace std;

	Object LoadPlugin(Env env, Object exports);    // forward declaration
	NODE_API_MODULE(addon, LoadPlugin)       // declares _module

        Object LoadPlugin(Env env, Object exports) {
        napi_module& module = _module;

        // do something with exports
        return exports;
    }


}

[mhdawson]

After a quick scan of the code I'm not sure how that sets _module but its going to be unintentional...

I think the correct way forward is for us to understand what info is needed from the module and see if there is a way to provide that.

[raffaeler]

I totally agree that _module is certainly not a solid way to make an addon version-resistant.
In any case napi_module is a plain structure and not the Napi::Value I would expect if Module was exposed to the addon world.
Also, _module has the main C++ source filename which has nothing to do with the runtime location of the addon binary.

[gabrielschulhof]

@raffaeler why do you need access to module?

[raffaeler]

@gabrielschulhof Here is why:
nodejs/node-addon-api#449

(we can close one of the two threads, not sure which one)

[mhdawson]

Going to close this one a duplicate of nodejs/node-addon-api#449 as there is more discussion in the other thread.