Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node REPL broken from 11.10.* to 11.11.* on fish shell #26663

Closed
FabioAntunes opened this issue Mar 14, 2019 · 2 comments
Closed

Node REPL broken from 11.10.* to 11.11.* on fish shell #26663

FabioAntunes opened this issue Mar 14, 2019 · 2 comments

Comments

@FabioAntunes
Copy link

  • Version: 11.10.* to 11.11.*
  • Platform: OSX and Ubuntu 18.10
  • Subsystem: REPL
  • Subsystem: Fish version 2.7.1 and 3.0.1

Since version 11.10.* that node REPL is broken for fish shell.

How to reproduce:
Install fish shell
Install node 11.10.* or 11.11.*
Try to run node in REPL mode.
You will be getting this error message:

internal/modules/cjs/loader.js:615
    throw err;
    ^

Error: Cannot find module '/Users/fabioantunes'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:613:15)
    at Function.Module._load (internal/modules/cjs/loader.js:539:25)
    at Function.Module.runMain (internal/modules/cjs/loader.js:801:12)
    at internal/main/run_main_module.js:21:11

This line will change: Error: Cannot find module '/Users/fabioantunes'
Depending on the path you actually run node

@mattyclarkson
Copy link

Working fine for me on 3.0.2:

~ $ node --version; and fish --version; and node
v11.11.0
fish, version 3.0.2
>

@FabioAntunes
Copy link
Author

It seems that the issue is actually since node 11.10.* you can't start node repl if you pass an empty string.

One of my commands was doing this: node ""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants