-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vm: filename option to vm.runInNewContext() ignored #27055
Comments
Looking at it from another perspective, maybe it's just a documentation issue? From vm.md: ## vm.runInNewContext(code[, sandbox[, options]]) To me that reads as saying the |
Thinking about it more, I don't see a way of making it work the way I expected it to (no way to know if the second arg is the sandbox or the options object in a two arg call) so I'll go ahead and close this out and think about how to improve the docs. |
This should work according to the docs but currently doesn't:
It shows up as
evalmachine.<anonymous>
instead ofboom.js
.Confirmed with master and all release lines. It's apparently not a recent regression.
Regression test:
The text was updated successfully, but these errors were encountered: