-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream: readable.push(undefined) behaviour? #29765
Comments
ronag
changed the title
stream: push(undefined) behaviour?
stream: readable.push(undefined) behaviour?
Sep 29, 2019
4 tasks
This was referenced May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Noticed this while working on #29762.
What is the expected behaviour of:
It seems to get through
chunkInvalid
https://github.com/nodejs/node/blob/master/lib/_stream_readable.js#L340But can later fail with a null ref at
Stream._uint8ArrayToBuffer
https://github.com/nodejs/node/blob/master/lib/_stream_readable.js#L279Unless I'm missing something, shouldn't it really be a
ERR_INVALID_ARG_TYPE
?The text was updated successfully, but these errors were encountered: