Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document how we use Travis CI #30200

Closed
fhinkel opened this issue Nov 1, 2019 · 3 comments
Closed

doc: document how we use Travis CI #30200

fhinkel opened this issue Nov 1, 2019 · 3 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@fhinkel
Copy link
Member

fhinkel commented Nov 1, 2019

Our Onboarding and Collaborator guide only explain how we use Jenkins.

It's hard to tell if Travis CI is testing is redundant to Jenkins or not. I believe Travis CI builds the docs? Is green Travis CI required or optional for landing PRs?

Does anybody want to take this on and add one or two sentences to our onboarding docs? Thanks!

@fhinkel fhinkel added the doc Issues and PRs related to the documentations. label Nov 1, 2019
@richardlau
Copy link
Member

At the moment Travis is advisory and completely optional (none of our tooling looks at the results). This may change (#29770). (As an aside I'm hesitant to switch over main build and test to Travis as I can't guarantee we'll be able to stay under Travis' current 50min build time limit (we're right up to it if large parts of V8 need recompilation).)

The only thing Travis currently tests that isn't tested on Jenkins is the commit message linting and that is done as part of node-core-utils if you are using it to land PRs.

@richardlau
Copy link
Member

Mentioning Travis is one of the checkboxes in #30116.

@fhinkel
Copy link
Member Author

fhinkel commented Jan 9, 2020

OK, thanks!

@fhinkel fhinkel closed this as completed Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

No branches or pull requests

2 participants