Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error building 12.13.1-proposal branch with Python 3: gyp-mac-tool: cannot use a string pattern on a byte-like object #30454

Closed
cakoose opened this issue Nov 13, 2019 · 3 comments

Comments

@cakoose
Copy link

cakoose commented Nov 13, 2019

I read that Node 12.13.1 is adding preliminary/experimental support for building with Python 3 (#30352). Filing this in case it's useful for that effort.

Node: 12.13.1-proposal branch (481b503)
MacOS 10.14.6
Python: 3.8.0

$ make -j4
...
Traceback (most recent call last):
  File "./gyp-mac-tool", line 711, in <module>
    sys.exit(main(sys.argv[1:]))
  File "./gyp-mac-tool", line 31, in main
    exit_code = executor.Dispatch(args)
  File "./gyp-mac-tool", line 46, in Dispatch
    return getattr(self, method)(*args[1:])
  File "./gyp-mac-tool", line 268, in ExecFilterLibtool
    if not libtool_re.match(line) and not libtool_re5.match(line):
TypeError: cannot use a string pattern on a bytes-like object
...

(I'm not blocked; I'm able to build with Python 2.)

@targos
Copy link
Member

targos commented Nov 13, 2019

@cakoose thanks for trying it! Does #30272 fix the build for you?

@cakoose
Copy link
Author

cakoose commented Nov 13, 2019

I cherry-picked 0673dfc and the build worked with Python 3.8.0!

@targos
Copy link
Member

targos commented Nov 14, 2019

Fix included in v12.13.1-proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants