-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v10.x CI failures #30639
Comments
They seem to be intermittently flaky - |
I reran the tests on some old v10.x releases and those are showing failures now too (v10.15.0 run). I'm fairly certain I've not seen these failures, at least to this extent, before. @nodejs/build have there been any changes to our Windows infrastructure recently? |
@joaocgreis can you comment on any changes to the Windows infa? |
Seeing the same failures across historic releases: v10.10.0 - https://ci.nodejs.org/job/node-test-binary-windows/25724/ Failures always seem to be on - |
My run of v10.17.0 once those two machines were taken offline passed 🎉 |
This was caused by an environment variable @nodejs/async_hooks is this interaction a bug? Or perhaps https://github.com/nodejs/node/blob/v10.x-staging/test/async-hooks/init-hooks.js should check if the variable is defined and fail with a clear message? @bcoe @Trott I see this variable defined in the Windows coverage job. I cleared the user variable from these two machines and a few Windows 2012 ones. I don't know if either of you set it, but if you did and need it let me know and we'll find a way. |
I set it in node-test-binary-windows-coverage. If it was set in node-test-binary-windows, that was either a mistake on my part or something done by someone else. Probably my mistake, so I'm really sorry for the trouble! |
@Trott that was not it, the variable was not set in the Jenkins job. It was actually a persistent variable (similar to adding an export to |
v10.x-staging: https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_debug_x64/16373/ |
@nodejs/build ... does this need to remain open? |
I think the specific issues here have been resolved. I've volunteered to prepare the next Node.js 10.x release so I'll guess I'll find out firsthand otherwise 😅. (nodejs/build#2072 remains open because to resolve this issue we reverted the change to run flaky tests in the debug builds (currently we skip them).) |
https://ci.nodejs.org/job/node-test-binary-windows/25706/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=0/consoleFull
There seem to be some async_hooks failures.
The text was updated successfully, but these errors were encountered: