-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to build nodejs #30949
Comments
It is probably because your python path has a trailing backslash. For compatible with no backslash case the full path would be something like I think this behavior could just be ignored if it does not cause other problems. |
I think that seems fine to me, but I’d wonder why it’s not failing for anybody else? |
Sure. Questions 1 and 2 are more important. BTW, my python path does not have trailing slash, even if I change to the path to the exe it still has 2 slashes. But if it is unrelated, we can ignore it I agree.
so should a pr be opened? |
Probably https://bugs.python.org/issue24404 which says it was fixed from Python 2.7.1 onwards (the OP is using Python 2.7.0). |
Unable to reproduce and there's been no further activity. Closing but we can reopen if necessary |
Installed python 2.7 and python 3.6 and added both pythons to PATH and started vcbuild.bat, and got error:
Now the questions are:
C:\Program Files\Python27\\python.exe
?Google search tells me that
BZ2File
does not support the context manager protocol. The following patch fixes the issue for me:Should this fix be added to the master?
The text was updated successfully, but these errors were encountered: