Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test "test-process-chdir" fails on El Capitan #3108

Closed
tciuro opened this issue Sep 29, 2015 · 4 comments
Closed

Test "test-process-chdir" fails on El Capitan #3108

tciuro opened this issue Sep 29, 2015 · 4 comments
Labels
macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests.

Comments

@tciuro
Copy link

tciuro commented Sep 29, 2015

Hello,

Running the tests on v4.1.1 reveals one failure:

➜  node-v4.1.1  make test
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C out BUILDTYPE=Release V=1
make[1]: Nothing to be done for `all'.
ln -fs out/Release/node node
Running main() from gtest_main.cc
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from UtilTest
[ RUN      ] UtilTest.ListHead
[       OK ] UtilTest.ListHead (0 ms)
[----------] 1 test from UtilTest (0 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (0 ms total)
[  PASSED  ] 1 test.
/usr/bin/python tools/test.py --mode=release message parallel sequential -J
=== release test-process-chdir ===                                             
Path: parallel/test-process-chdir
assert.js:89
  throw new assert.AssertionError({
  ^
AssertionError: '/Users/tito/Desktop/node-v4.1.1/test/tmp.5/weird 쎤쎫쎯 characters áâã' === '/Users/tito/Desktop/node-v4.1.1/test/tmp.5/weird 쎤쎫쎯 characters áâã'
    at Object.<anonymous> (/Users/tito/Desktop/node-v4.1.1/test/parallel/test-process-chdir.js:20:8)
    at Module._compile (module.js:434:26)
    at Object.Module._extensions..js (module.js:452:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:475:10)
    at startup (node.js:117:18)
    at node.js:951:3
Command: out/Release/node /Users/tito/Desktop/node-v4.1.1/test/parallel/test-process-chdir.js
[01:09|% 100|+ 918|-   1]: Done                                                
make: *** [test] Error 1

I have reproduced this easily. I applied the following patch to test the output:

https://gist.github.com/indutny/acb44b3c58294334fe10

The results looks like this:

Path: parallel/test-process-chdir
2f55736572732f7469746f2f4465736b746f702f6e6f64652d76342e312e312f746573742f706172616c6c656c
2f55736572732f7469746f2f4465736b746f702f6e6f64652d76342e312e312f746573742f746d702e32
assert.js:89
  throw new assert.AssertionError({
  ^
AssertionError: '/Users/tito/Desktop/node-v4.1.1/test/tmp.2/weird 쎤쎫쎯 characters áâã' === '/Users/tito/Desktop/node-v4.1.1/test/tmp.2/weird 쎤쎫쎯 characters áâã'
    at Object.<anonymous> (/Users/tito/Desktop/node-v4.1.1/test/parallel/test-process-chdir.js:22:8)
@tciuro
Copy link
Author

tciuro commented Sep 29, 2015

New patch updated:

https://gist.github.com/indutny/acb44b3c58294334fe10

The results now look like:

Path: parallel/test-process-chdir
2f55736572732f7469746f2f4465736b746f702f6e6f64652d76342e312e312f746573742f746d702e352f776569726420e1848ae185a7e186abe1848ae185a7e186b2e1848ae185a7e186b620636861726163746572732061cc8161cc8261cc83
2f55736572732f7469746f2f4465736b746f702f6e6f64652d76342e312e312f746573742f746d702e352f776569726420ec8ea4ec8eabec8eaf206368617261637465727320c3a1c3a2c3a3
assert.js:89
  throw new assert.AssertionError({
  ^
AssertionError: '/Users/tito/Desktop/node-v4.1.1/test/tmp.5/weird 쎤쎫쎯 characters áâã' === '/Users/tito/Desktop/node-v4.1.1/test/tmp.5/weird 쎤쎫쎯 characters áâã'
    at Object.<anonymous> (/Users/tito/Desktop/node-v4.1.1/test/parallel/test-process-chdir.js:22:8)

@brendanashworth brendanashworth added the test Issues and PRs related to the tests. label Sep 29, 2015
@indutny
Copy link
Member

indutny commented Sep 29, 2015

It is about Chinese characters and latest OS X (I think):

  1. This is what we write in hex: 'e1848ae185a7e186ab', which is three chars: , , and . Combined together they are
  2. OS X reports it back as 'ec8ea4', which is

I think we should just fix the test and make it pass a single char. Thoughts?

@brendanashworth brendanashworth added the macos Issues and PRs related to the macOS platform / OSX. label Sep 29, 2015
@thefourtheye
Copy link
Contributor

If it is a problem with the OS X then let's use a different name just for that environment alone.

@silverwind
Copy link
Contributor

This is a duplicate of #2165, my proposed fix is at #3007.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

5 participants