Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: move Makefile checks to configure #321

Closed
jbergstroem opened this issue Jan 13, 2015 · 3 comments
Closed

build: move Makefile checks to configure #321

jbergstroem opened this issue Jan 13, 2015 · 3 comments

Comments

@jbergstroem
Copy link
Member

There's a few things checked in Makefile that could be moved to configure so it's not executed every time Makefile is sourced (which seems to happen multiple times while building with gmake).

If others think this is a good idea I'll whip a patch for a review.
@bnoordhuis
Copy link
Member

What things are you thinking of?

@jbergstroem
Copy link
Member Author

Just had a run through and it actually isn't being sourced as often as I initially believed. Let's just close this and I'll just file PR's with minor improvements as I go along instead?

@bnoordhuis
Copy link
Member

Sounds like a plan. Thanks for following up, Johan.

@snyk-bot snyk-bot mentioned this issue Dec 6, 2021
Open
This was referenced Jan 12, 2022
Open
Open
@snyk-bot snyk-bot mentioned this issue Feb 1, 2022
Open
This was referenced Feb 28, 2022
Open
Open
@snyk-bot snyk-bot mentioned this issue May 3, 2022
Open
@NOUIY NOUIY mentioned this issue Jun 23, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jun 28, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jul 19, 2022
Open
@NOUIY NOUIY mentioned this issue Aug 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbergstroem @bnoordhuis