Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: out of memory on large write #32598

Closed
bnoordhuis opened this issue Apr 1, 2020 · 1 comment
Closed

tls: out of memory on large write #32598

bnoordhuis opened this issue Apr 1, 2020 · 1 comment
Labels
tls Issues and PRs related to the tls subsystem.

Comments

@bnoordhuis
Copy link
Member

Here's the stack trace:

/usr/local/bin/node[833]: ../src/env-inl.h:899:char* node::Environment::Allocate(size_t): Assertion `(ret) != (nullptr)' failed.
 1: 0x9bcac0 node::Abort() [/usr/local/bin/node]
 2: 0x9bcb47  [/usr/local/bin/node]
 3: 0xad9a1b node::TLSWrap::DoWrite(node::WriteWrap*, uv_buf_t*, unsigned long, uv_stream_s*) [/usr/local/bin/node]
 4: 0xa6876e node::StreamBase::Writev(v8::FunctionCallbackInfo<v8::Value> const&) [/usr/local/bin/node]
 5: 0xa6df6e void node::StreamBase::JSMethod<&node::StreamBase::Writev>(v8::FunctionCallbackInfo<v8::Value> const&) [/usr/local/bin/node]
 6: 0xb840cc  [/usr/local/bin/node]
 7: 0xb85ed7 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [/usr/local/bin/node]
 8: 0x134f199  [/usr/local/bin/node]

Version: v12.16.1 (installed via apt using the NodeSource repository) and v12.9.1 (using the binary from nodejs.org)
OS: Ubuntu 18.04.3 x64

It does not seem to happen running 12.9.1 on macOS 10.15.3. My best guess is that (in my code at least) the aws-sdk library is triggering it when uploading a large file. I'm not sure how to debug further; I don't really know what to do with this crash log. Will try to get that NODE_DEBUG_NATIVE=tls log if it helps.

Originally posted by @jakelazaroff in #30896 (comment)


This is NodeArrayBufferAllocator::AllocateUninitialized(size) failing to allocate the requested memory.

The error message could be better, perhaps it should even be a run-time JS exception.

@bnoordhuis bnoordhuis added the tls Issues and PRs related to the tls subsystem. label Apr 1, 2020
@bnoordhuis
Copy link
Member Author

Seeing that this is a bug report for an out-of-support release line and no similar reports have been received for newer release lines, I'll go and close this.

@bnoordhuis bnoordhuis closed this as not planned Won't fix, can't repro, duplicate, stale Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

No branches or pull requests

1 participant