-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v10.x] V8 builds are broken #35504
Comments
v10.0.0 to v10.11.0 fail due to
v10.12.0 through to v10.15.0 fails with
v10.15.1 and later fail with compilation error we're currently seeing:
|
I'm assuming that we did have the V8 CI passing on v10.x at some point in the past. In terms of why it's failing now, one or more of the following may be responsible:
|
Try adding |
Thanks, I'll try cherry-picking #32113 across to |
Test build passed on the IBM platforms with that cherry-pick 🎉. Test failures on x64 Linux would require the nearform machine to be brought back online to test. |
nearform machines are back. Will attempt to cherry-pick #27364 to see if that fixes things. |
Cherry-picked 3b2633e and 546d6cd across to Test V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3456/ |
Cherry picking the test changes gives us a green CI on |
What steps will reproduce the bug?
The V8 CI (https://ci.nodejs.org/job/node-test-commit-v8-linux/) is currently broken on v10.x (see #35393 (comment)).
How often does it reproduce? Is there a required condition?
All the time.
What is the expected behavior?
V8 CI should pass.
What do you see instead?
V8 CI consistently fails on all three platforms.
Additional information
Going to try bisecting v10.x releases.
The text was updated successfully, but these errors were encountered: