-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async output in repl is showing after the prompt #35895
Comments
Ok i'm testing the scenario from master now. The scenario mentioned:
is now crashing the repl altogether. |
When I try it in 15.11.0 or in today's nightly or canary, I get the same output, now it seems OK: > new Promise((rs, rj) => { rj(); })
Promise { <rejected> undefined }
> Uncaught undefined
> // Prompt is here! |
@vsemozhetbyt Yes the other issues still seems to be present. |
The reason the Uncaught part now works is that it does not cause a deprecation warning anymore due to the specified unhandled rejection warning. It is tricky to fix this, since we write on the stream directly. We do not use the regular input methods for e.g., warnings. And what should happen for async writes on the stream? Should they be marked specially? It is currently intermixed with the line input and visualized as input. That's incorrect but difficult to fix, especially in a way that is easy to understand for users. |
This issue has been stale for a long time. Also, it focuses on an old, no longer supported version of Node. I'll close it for those reasons. If needed, feel free to reopen. |
The text was updated successfully, but these errors were encountered: