You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
gengjiawen opened this issue
Jan 27, 2021
· 1 comment
Labels
buildIssues and PRs related to build files or the CI.v8 engineIssues and PRs related to the V8 dependency.windowsIssues and PRs related to the Windows platform.
The text was updated successfully, but these errors were encountered:
Lxxyx
added
build
Issues and PRs related to build files or the CI.
v8 engine
Issues and PRs related to the V8 dependency.
windows
Issues and PRs related to the Windows platform.
labels
Jan 27, 2021
While working on #55249 I stumbled upon this issue
I'm not sure what the situation was like when this was opened, but now, PCH is enabled by default (and will be for ClangCL as well). I tried including headers from the mentioned v8-cmake PR in v8_pch.h, but that did not improve compile time. With all this considered, @gengjiawen can this issue be closed?
buildIssues and PRs related to build files or the CI.v8 engineIssues and PRs related to the V8 dependency.windowsIssues and PRs related to the Windows platform.
This patch bnoordhuis/v8-cmake#43 bring v8 build from 72min to 13min for v8.
I think apply this on our side will make us less suffer dealing with v8 on windows.
Not sure our https://github.com/nodejs/node/blob/master/tools/msvs/pch/v8_pch.h is enabled by default. But our surely take much more time, maybe can fix by add more headers ?
cc @nodejs/v8 @nodejs/platform-windows
The text was updated successfully, but these errors were encountered: