V8 upgrade to 4.6.85.23: Can no longer create a Buffer instance with nullptr

[TooTallNate]

In ref we do:

Nan::NewBuffer(nullptr, 0, wrap_pointer_cb, nullptr);

i.e. a Buffer instance backed by the null pointer, useful for ffi and other things. d8011d1 seems to have broken this functionality. Summoning a V8 guru (@indutny 😉) to possibly find out what's going on?

Thanks!

[indutny]

This is fixed by 827ee49, AFAIK. It just hasn't yet made its way to v5.0.0

[TooTallNate]

Confirmed working correctly on master. I do remember seeing that commit when it landed, forgot about it I guess. 🍻 for the added test case!

[TooTallNate]

And thanks for the fast response Fedor!

[indutny]

No problem! :)