-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLSSocket.prependOnceListener('session')
results in an abort
#38135
Labels
Comments
BTW, |
aduh95
added
confirmed-bug
Issues with confirmed bugs.
repl
Issues and PRs related to the REPL subsystem.
labels
Apr 7, 2021
Can reproduce on master and v14.x, but only in REPL: cannot reproduce with eval ( |
Not related to the REPL. const tls = require('tls');
tlsSocket = tls.connect('r','\u{85}');
tlsSocket.on('error', () => {})
setTimeout(() => {
tlsSocket.prependOnceListener('session',(session)=>{});
}, 1000) |
Linkgoron
added a commit
to Linkgoron/node
that referenced
this issue
Apr 9, 2021
Fix an issue where adding a session or keylog listener on a tlsSocket caused an abort. fixes: nodejs#38133 fixes: nodejs#38135
Linkgoron
added a commit
to Linkgoron/node
that referenced
this issue
Apr 9, 2021
Fix an issue where adding a session or keylog listener on a tlsSocket after it was destroyed caused a segfault. fixes: nodejs#38133 fixes: nodejs#38135
Linkgoron
added a commit
to Linkgoron/node
that referenced
this issue
Apr 9, 2021
Fix an issue where adding a session or keylog listener on a tlsSocket after it was destroyed caused a segfault. fixes: nodejs#38133 fixes: nodejs#38135
Linkgoron
added a commit
to Linkgoron/node
that referenced
this issue
Apr 9, 2021
Fix an issue where adding a session or keylog listener on a tlsSocket after it was destroyed caused a segfault. fixes: nodejs#38133 fixes: nodejs#38135
Linkgoron
added a commit
to Linkgoron/node
that referenced
this issue
Apr 9, 2021
Fix an issue where adding a session or keylog listener on a tlsSocket after it was destroyed caused a segfault. fixes: nodejs#38133 fixes: nodejs#38135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
What steps will reproduce the bug?
Setup a node instance,
and run the following javascript code.
Then an abort occurs.
This PoC is very similar to #38133, but the core dump traces and the behaviors of nodejs are different. I think it's worth analyzing for both of them.
How often does it reproduce? Is there a required condition?
This problem can always be triggered following the steps above.
What is the expected behavior?
If any error occurs, an exception or other similar error-reporting stuff should be thrown. There is no reason to abort the whole node process.
What do you see instead?
Additional information
The text was updated successfully, but these errors were encountered: