Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build failed on macOS #40996

Closed
gengjiawen opened this issue Nov 28, 2021 · 2 comments · Fixed by #41146
Closed

build failed on macOS #40996

gengjiawen opened this issue Nov 28, 2021 · 2 comments · Fixed by #41146
Labels
build Issues and PRs related to build files or the CI. macos Issues and PRs related to the macOS platform / OSX.

Comments

@gengjiawen
Copy link
Member

[1391/3715] ACTION icudata: icudata_cc7672230cb6f4a4cb1b079ff599d36f
generating assembly code for ../../out/Release/gen/icudt70.dat
[1545/3715] ACTION Generating inspector protocol sources from protocol json
FAILED: gen/inspector-generated-output-root/src/inspector/protocol/Forward.h gen/inspector-generated-output-root/src/inspector/protocol/Protocol.cpp gen/inspector-generated-output-root/src/inspector/protocol/Protocol.h gen/inspector-generated-output-root/src/inspector/protocol/Console.cpp gen/inspector-generated-output-root/src/inspector/protocol/Console.h gen/inspector-generated-output-root/src/inspector/protocol/Debugger.cpp gen/inspector-generated-output-root/src/inspector/protocol/Debugger.h gen/inspector-generated-output-root/src/inspector/protocol/HeapProfiler.cpp gen/inspector-generated-output-root/src/inspector/protocol/HeapProfiler.h gen/inspector-generated-output-root/src/inspector/protocol/Profiler.cpp gen/inspector-generated-output-root/src/inspector/protocol/Profiler.h gen/inspector-generated-output-root/src/inspector/protocol/Runtime.cpp gen/inspector-generated-output-root/src/inspector/protocol/Runtime.h gen/inspector-generated-output-root/src/inspector/protocol/Schema.cpp gen/inspector-generated-output-root/src/inspector/protocol/Schema.h gen/inspector-generated-output-root/include/inspector/Debugger.h gen/inspector-generated-output-root/include/inspector/Runtime.h gen/inspector-generated-output-root/include/inspector/Schema.h 
cd ../../tools/v8_gypfiles; export BUILT_FRAMEWORKS_DIR=/Users/jiawengeng/code/node/out/Release; export BUILT_PRODUCTS_DIR=/Users/jiawengeng/code/node/out/Release; export CONFIGURATION=Release; export EXECUTABLE_NAME=libv8_base_without_compiler.a; export EXECUTABLE_PATH=libv8_base_without_compiler.a; export FULL_PRODUCT_NAME=libv8_base_without_compiler.a; export MACH_O_TYPE=staticlib; export PRODUCT_NAME=v8_base_without_compiler; export PRODUCT_TYPE=com.apple.product-type.library.static; export SDKROOT=/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk; export SRCROOT=/Users/jiawengeng/code/node/out/Release/../../tools/v8_gypfiles; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Users/jiawengeng/code/node/out/Release; export TEMP_DIR="${TMPDIR}"; export XCODE_VERSION_ACTUAL=1310;python ../../deps/v8/third_party/inspector_protocol/code_generator.py --jinja_dir ../../deps/v8/third_party --output_base ../../out/Release/gen/inspector-generated-output-root/src/inspector --config ../../deps/v8/src/inspector/inspector_protocol_config.json --inspector_protocol_dir ../../deps/v8/third_party/inspector_protocol
Traceback (most recent call last):
  File "../../deps/v8/third_party/inspector_protocol/code_generator.py", line 702, in <module>
    main()
  File "../../deps/v8/third_party/inspector_protocol/code_generator.py", line 584, in main
    jinja_env = initialize_jinja_env(jinja_dir, config.protocol.output, config)
  File "../../deps/v8/third_party/inspector_protocol/code_generator.py", line 190, in initialize_jinja_env
    import jinja2
  File "/Users/jiawengeng/code/node/deps/v8/third_party/jinja2/__init__.py", line 33, in <module>
    from jinja2.environment import Environment, Template
  File "/Users/jiawengeng/code/node/deps/v8/third_party/jinja2/environment.py", line 16, in <module>
    from jinja2.defaults import BLOCK_START_STRING, \
  File "/Users/jiawengeng/code/node/deps/v8/third_party/jinja2/defaults.py", line 32, in <module>
    from jinja2.tests import TESTS as DEFAULT_TESTS
  File "/Users/jiawengeng/code/node/deps/v8/third_party/jinja2/tests.py", line 13, in <module>
    from collections.abc import Mapping
ImportError: No module named abc
[1556/3715] CXX obj/deps/v8/src/compiler/v8_compiler.js-call-reducer.o
ninja: build stopped: subcommand failed.

Using command

jiawengeng@Jiawens-MacBook-Pro ~/c/node (master)> ./configure --ninja
Node.js configure: Found Python 3.9.8...
INFO: configure completed successfully
jiawengeng@Jiawens-MacBook-Pro ~/c/node (master)> time ninja -C out/release
@gengjiawen gengjiawen added feature request Issues that request new features to be added to Node.js. and removed feature request Issues that request new features to be added to Node.js. labels Nov 28, 2021
@mscdex
Copy link
Contributor

mscdex commented Nov 28, 2021

Seems like python 2.x is being used instead when it runs code_generator.py. I wonder if there are some stale build files causing this?

Did you try cleaning all build files or even try building using the latest master tarball from github in another directory to make sure you have an absolute latest, clean environment?

@VoltrexKeyva VoltrexKeyva added build Issues and PRs related to build files or the CI. macos Issues and PRs related to the macOS platform / OSX. labels Nov 28, 2021
@gengjiawen
Copy link
Member Author

Seems like python 2.x is being used instead when it runs code_generator.py. I wonder if there are some stale build files causing this?

Did you try cleaning all build files or even try building using the latest master tarball from github in another directory to make sure you have an absolute latest, clean environment?

It's a clean build. Not sure it's related ninja. The plain old make works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. macos Issues and PRs related to the macOS platform / OSX.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants