-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nominating new Release team members #4319
Comments
+1 to both! |
yar, +1 on both, particularly since @thealphanerd has been doing a lot of the heavy lifting with staging branches recently |
+1 to both. I think we should cap it at those two for the time being though. |
One more +1. |
I suppose the thing to do it to bring it up on the next TSC meeting then. |
@Fishrock123 ... I'm not sure that's necessary. Seems like everyone is in agreement :-) |
I wouldn't mind a CTC quorum on this, releases are a big deal and we should treat it as such cause you get access to put binaries on the server for redistribution so the CTC is effectively delegating its trust to these individuals. Enough +1's in here would probably be sufficient but I'd prefer a meeting so we have a clearer chain of evidence. |
OK. Works for me |
@thealphanerd / @evanlucas note: there's no solid process for this, but generally, we'll try to get you to do a patch or minor release while we are around to help. The actual release process is something you can only really learn to do by actually doing it. :) |
Works for me! |
ditto. Perhaps I can shadow @jasnell on next weeks LTS release |
@evanlucas & @thealphanerd could you make sure to have GPG keys setup as per https://github.com/nodejs/node/blob/master/doc/releases.md#3-a-publicly-listed-gpg-key? Also having them on keybase.io is nice (let me know if you need an invite). |
gpg --keyserver pool.sks-keyservers.net --recv-keys 38CE40DEEE898E15 |
mine is |
From the CTC meeting, no objections. @thealphanerd / @evanlucas Who wants to go first? Next week's stable release is as good as any to be your first. :) |
doc/releases.md shows most of the process, and it would be good to familiarize yourself with it beforehand, although you'll probably follow along with it as you do your first release. |
I'd be up for trying this. |
@thealphanerd as you go through the process, could you take note of anything important that's missing from doc/releases.md? |
absolutely |
@evanlucas / @thealphanerd Could you make PR's adding your GPG keys to https://github.com/nodejs/node#release-team? We'll get the build team to add them then. |
@evanlucas which key would you like us to use to give you promote access on the web server? https://github.com/evanlucas.keys — you'll need this done before you can run the full release process. |
ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCvMVfdEy2ME3ZK+q+ib62rWWHNaUUmWDwaV/iMCfA3Vyisp2IXbQcbEt4hFduQX0nbbDnT6IKVRAzU7ya3H6m0ctiu7NkjejxseBQURrQYgMTS6F9Li9OE5vkyRfGr6Rx+4HQ8Ll6OtamE5dcEHy629rgsnFZQxOo/wYLPsEaUZuRrd9jEMiyDQghlzU+PtYKTO2B+U7qtCUU4tjpSfFBWV9V1XUmKEwAZfxeKWkWVcLpmFrE+6a+YKFz2uJNkFFRXdyVBMyZU9vLeFffNZSRX0lGllE57xF6A0f5yN7BIE48+qbJqfW/cADmH41ewuQEjXSjv3Ep6g17p5sjk0pu5 will work. Thanks! |
Done, you should be good to go for a release now, maybe grab the next one, could even start the proposal later this week or early next week to line it up for next week or the week after. I've been aiming for Tuesday releases where possible, I think @Fishrock123 has too. It's a bit of a sweet spot for releases but I don't think we need to be strict about it. I'd also prefer closer to a 2 weekly release average but I know @Fishrock123 has been pushing closer to 1. |
Will do. Thanks! |
You mean bi-weeky or twice per week? |
How about fortnightly :-) |
You do not have to be a TSC / CTC member to do releases.
Nominating two so far (also since they've volunteered their time)
cc @nodejs/ctc
The text was updated successfully, but these errors were encountered: