-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Out of date node-addon-examples #4339
Comments
/cc @nodejs/addon-api |
I would be more than happy to help, what is it that is missing from the page? I just checked most of the examples with the v0.12 tag are working with v4.2.4 |
@Peteyy ... largely just need someone to go through and make sure that the examples are fully up to date, compile, do not use any deprecated APIs and reflect current best practices. |
@jasnell I see the mentor-available label on the issue, is there anybody I could contact and what is the preferred medium? |
Commenting on github is usually best. Just mention either myself or @rvagg and I'm sure we'll be able to get you pointed in the right direction |
I'm working on the first example |
Can this be closed?
Or am I misunderstanding the issue here? |
Blocked by people availability in nodejs/node-addon-examples I think, I just don't have the bandwidth. Would love help from @nodejs/addon-api folks to review existing work there tho. |
See: nodejs/node-addon-examples#46 ...
The Addon examples in the node-addon-examples registry have fallen behind and no longer match the documentation (even tho the documentation says that all of the examples can be downloaded). Updating these could be a good first contribution for someone who wishes to learn more about Addon development.
The text was updated successfully, but these errors were encountered: