Extend N-API to cover libnode

[mmomtchev]

What is the problem this feature will solve?

Currently when using libnode one has to use raw V8 primitives or to manually construct a napi_env by including node_api_internals.h which is normally not exported and has other internal dependencies.

What is the feature you are proposing to solve the problem?

Add a N-API primitive for creating a Node environment (the code in embedtest.cc) that constructs a napi_env

What alternatives have you considered?

• Using raw V8 primitives - very impractical and not portable
• Including node_api_internals.h and manually constructing a napi_env - requires access to Node internal structures that are normally not exported

[legendecas]

Duplicate of #23265

[mmomtchev]

@legendecas one very significant difference of this proposal and my implementation is that draining the event loop is a separate API call - something that I did consider too. I wonder if there is any point in doing this? The current implementation does not allow to wait for all async tasks to finish and then to reuse the environment - at this point it must be destroyed.
Also I see an API call for creating an environment out of a libuv event loop? Is it needed?

[legendecas]

The current implementation does not allow to wait for all async tasks to finish and then to reuse the environment - at this point it must be destroyed.

I'm not sure I get your point about "current implementation" correctly. If you are referring to the Node.js embedder API, I think people can already get the uv loop and drain the queue with APIs like node::GetCurrentEventLoop.

[mmomtchev]

@legendecas I am open to all constructive suggestions.

[mmomtchev]

I am closing this issue so that there is a single discussion