-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unhandled exception output encoding is incorrect in windows console. #4754
Comments
Seems to be windows-specific. Cannot reproduce on OS X.
I want to say there was another issue similar to this...something about colors in an error message. I'll see if I can dig it up. /cc @nodejs/platform-windows |
So it looks like https://github.com/nodejs/node/blob/master/deps/v8/src/base/platform/platform-win32.cc#L556 may be what is causing this. More info on |
The issue I mentioned earlier is #3734. Seems to be related. |
让我来用中文抱怨一句:你妹啊,老子以前的这个issues在joyent那放了几百年没人处理,现在那么快就有反映了,果然开源打法好。 |
This could also be related to nodejs/node-v0.x-archive#7940 |
cc @nodejs/nodejs-cn, could you translate? |
@Fishrock123 you mean heroboy's reply? |
@XadillaX Yeah (Or reply if you can, either way) |
|
I'm unable to reproduce this issue on Windows. What's your Node.js version? In which encoding is main.js saved? |
@seishun v4.2.1 and main.js saved as utf8. |
Tried it on another computer with plain cmd and Node.js v4.2.1 and couldn't reproduce it. What's your locale and |
@seishun I just tired in my home PC, the output is ok,
the broken output occurs in my work pc,
|
hi, I think this issues is duplicated with #3284, and has been fixed.I will close this. |
main.js:
output:
The text was updated successfully, but these errors were encountered: